Remove "Details" from breadcrumb and JSON+JD on Group top page
What does this MR do?
Removes "Details" from breadcrumb and JSON+JD on Group (top-level and sub-) top page.
Relates to !47817 (merged) (for Project)
Screenshots (strongly suggested)
Before | After |
---|---|
TBD | ![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [n/a] Documentation (if required)
-
Code review guidelines - [n/a] Merge request performance guidelines
-
Style guides -
Separation of EE specific content
Related to #284008 (closed)
Merge request reports
Activity
changed milestone to %13.6
added Community contribution SEOImprovement UI polish UX subgroups labels
marked the checklist item Separation of EE specific content as completed
marked the checklist item Style guides as completed
added 1 commit
- e73c44eb - Remove "Details" from breadcrumb and JSON+JD on Subgroup top page
added frontend label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Dave Pisek ( @dpisek
) (UTC+11)Andrew Fontaine ( @afontaine
) (UTC-5)test Quality for spec/features/*
Sanad Liaquat ( @sliaquat
) (UTC+5)Maintainer review is optional for test Quality for spec/features/*
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 979527db and 36239b5b
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.14 MB 3.14 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖marked the checklist item Code review guidelines as completed
assigned to @tnir
Setting label(s) devopsmanage ~"group::access" sectiondev based on ~"group::access" subgroups.
mentioned in merge request !47816 (closed)
marked the checklist item Changelog entry as completed
added 540 commits
-
e73c44eb...06c0abe6 - 539 commits from branch
master
- 2fc33428 - Remove "Details" from breadcrumb and JSON+JD on Group top page
-
e73c44eb...06c0abe6 - 539 commits from branch
mentioned in issue #285087 (closed)
changed milestone to %13.7
added missed:13.6 label
added 279 commits
-
2fc33428...051735fe - 278 commits from branch
master
- 36239b5b - Remove "Details" from breadcrumb and JSON+JD on Group top page
-
2fc33428...051735fe - 278 commits from branch
@psimyn Could you review this like !47817 (merged)?
- Resolved by Takuya Noguchi
this LGTM @tnir - will ping for additional review since !46991 (merged) was pretty recent
@fjsanpedro can you please give this a review?
assigned to @fjsanpedro
unassigned @fjsanpedro
mentioned in merge request !47817 (merged)
enabled an automatic merge when the pipeline for df8ecf07 succeeds
mentioned in commit 801d158b
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #284008 (closed)
mentioned in issue #35819 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label