Remember project ordering when inside groups

What does this MR do?

Persists project sort order across both the project dashboard and the group projects list.

At the same time, added a missing option to sort projects by name (desc) on the dashboard.

Addresses request with 100 upvotes #18871 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Code review guidelines
• Merge request performance guidelines
• Style guides

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

changed milestone to %13.7

changed milestone to %Next 4-6 releases

added Manage [DEPRECATED] customer devopsfoundations frontend sectiondev settings typefeature labels

added backend label

Danger has errored

[!] Invalid Dangerfile file: [31m [!] Invalid Dangerfile file: git --git-dir=/builds/gitlab-org/gitlab/.git --work-tree=/builds/gitlab-org/gitlab -c color.ui=false diff --numstat 440692a34596a4799635d6569ec705bb90e6c0c6 434c5581cee5a7d49de634088c1757acd7d375d4 2>&1:fatal: bad object 434c5581. Updating the Danger gem might fix the issue. Your Danger version: 8.0.6, latest Danger version: 8.2.1 [0m

from danger/commit_messages/Dangerfile:89

-------------------------------------------

> linter.lint

end

-------------------------------------------

. Updating the Danger gem might fix the issue. Your Danger version: 8.0.6, latest Danger version: 8.2.1

 #  from danger/commit_messages/Dangerfile:89
 #  -------------------------------------------
 #   >   #  
 #  -------------------------------------------

Generated by Danger

resolved all threads

changed this line in version 2 of the diff

added 1 commit

• 434c5581 - Add merge request # and author to changelog

Compare with previous version

added Community contribution label

added 1 commit

• 440692a3 - Fixing up tests

Compare with previous version

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 6b976e32 and 0af193c6

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.15 MB	3.15 MB	-	0.0 %
mainChunk	1.95 MB	1.95 MB	-	0.0 %

---

Note: We do not have exact data for 6b976e32. So we have used data from: ed3c386e.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

added 2 commits

• b0844318 - Added set_sort_order overrides
• 285a63df - Removing use of instance variable

Compare with previous version

added 1 commit

• f7c8debf - Fixed missing arg

Compare with previous version

added 1 commit

• 254dec10 - Adding default values for tests

Compare with previous version

changed milestone to %13.7

mentioned in issue #18871 (closed)

added 1 commit

• 94d92f29 - Fix ee method override

Compare with previous version

changed the description

marked the checklist item Changelog entry as completed

added 1 commit

• bf9b1123 - Added project sort order persistence specs

Compare with previous version

added 544 commits

• bf9b1123...f1c82d9e - 542 commits from branch master
• feb6dc4a - Merge remote-tracking branch 'upstream/master' into 18871_remember_project_ordering
• e735e7c2 - Fix failing epics test by adding controller_name condition

Compare with previous version

changed the description

marked this merge request as ready

@robotmay_gitlab @tristan.read @sliaquat would you guys mind taking a first look at this please?

My thoughts are that it's rather messy and I would love to hear any ideas on an alternative approach. HOWEVER, I feel like maybe there is some "tech debt" here and the whole sorting helper maybe needs reworking a little bit.

To expand a little further on what led me to this conclusion... the sorting helper relies on overridden controller methods; sorting_field and default_sort_order for example. But often we want to use different multiple controllers/classes are being extended/included and the same controller is being used to display different "sortable lists".

Perhaps it would be better to always "pass" the arguments (like my new technique) and do away with the overridden methods? Unless there's something i'm missing which makes these favourable?

But anyway- that's not for this MR. I'm really keen to get this delivered "quickly" without huge refactoring as it's in such demand and such an old issue (100 votes/4 years old).

Thanks!

assigned to @robotmay_gitlab, @tristan.read, and @sliaquat

unassigned @robotmay_gitlab

mentioned in issue gitlab-com/www-gitlab-com#6605 (closed)

unassigned @sliaquat

added 1 commit

• f99e75ca - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

• 1950248f - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

• cc33ed59 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 120 commits

• cc33ed59...f6e3ac22 - 118 commits from branch master
• 535f1fd7 - Merge remote-tracking branch 'upstream/master' into 18871_remember_project_ordering
• d50b5478 - Applying suggestions

Compare with previous version

added 1 commit

• 5a20858f - Refactoring based on suggestions

Compare with previous version

assigned to @robotmay_gitlab

resolved all threads

marked the checklist item Style guides as completed

marked the checklist item Merge request performance guidelines as completed

approved this merge request

@leetickett The frontend looks good to me. I'll approve and pass to a maintainer

@psimyn would you mind giving this a maintainer review? Thanks

assigned to @psimyn and unassigned @tristan.read

added 331 commits

• 5a20858f...ad24346b - 330 commits from branch master
• 35c4e136 - Merge branch 'master' into '18871_remember_project_ordering'

Compare with previous version

approved this merge request

Thanks @leetickett! These changes look good to me. I've added one question/suggestion but I'll defer to @smcgivern's maintainer review as to whether it's necessary or not

assigned to @smcgivern and unassigned @robotmay_gitlab

approved this merge request

unassigned @psimyn

unassigned @smcgivern

added 174 commits

• 35c4e136...f737d8da - 172 commits from branch master
• baff5d29 - Merge branch 'master' into 18871_remember_project_ordering
• 6b347ead - Applying suggestions

Compare with previous version

added 1 commit

• 0af193c6 - Aligning param names

Compare with previous version

resolved all threads

assigned to @smcgivern

approved this merge request

enabled an automatic merge when the pipeline for b952aacc succeeds

Danger is failing due to more than 20 commits: #227814

I'll merge manually once the other jobs pass.

canceled the automatic merge

merged

mentioned in commit 95d2846d

mentioned in issue gitlab-com/gl-infra/scalability#672

added workflowstaging label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

mentioned in issue #23888

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label