Skip to content

Enable Ruby deprecation warnings in RSpec

Peter Leitzen requested to merge pl-enable-deprecation-warnings into master

What does this MR do?

Enable deprecation warnings by default and make them more visible to developers to ease upgrading to newer Ruby versions.

Relates to #257438 (comment 447929758)

Screenshots

Running e.g. rspec spec/lib/gitlab/cleanup/project_uploads_spec.rb (taken from #257438 (closed)) without and with deprecation warnings enabled:

Before After After with SILENCE_DEPRECATION=1
Screenshot_from_2020-11-16_11-43-01 Screenshot_from_2020-11-16_11-41-44 Screenshot_from_2020-11-17_11-15-22

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports