Skip to content

Add regulated attribute to compliance frameworks

Max Woolf requested to merge 273098-regulated-compliance-labels into master

What does this MR do?

  • Adds a new column, regulated, to compliance_management_frameworks table.
  • Adds a default value of true to all frameworks.
  • Makes no changes to the end-user experience. This is to be used as part of #255340 (closed).

Database Review

Migrate

== 20201116090328 AddRegulatedToComplianceFrameworks: migrating ===============
-- add_column(:compliance_management_frameworks, :regulated, :boolean, {:default=>true, :null=>false})
   -> 0.0047s
== 20201116090328 AddRegulatedToComplianceFrameworks: migrated (0.0047s) ======

Rollback

== 20201116090328 AddRegulatedToComplianceFrameworks: reverting ===============
-- remove_column(:compliance_management_frameworks, :regulated, :boolean, {:default=>true, :null=>false})
   -> 0.0018s
== 20201116090328 AddRegulatedToComplianceFrameworks: reverted (0.0103s) ======

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #220190 (closed)

Edited by Max Woolf

Merge request reports