Skip to content
Snippets Groups Projects

Improve pipeline security tab filter logic

Merged Daniel Tian requested to merge 210327-fix-followup-issues into master
All threads resolved!

What does this MR do?

This MR addresses the feedback left in !47294 (merged). The previous MR was merged quickly in order to fix a priority1 bug. This MR fixes the issues brought up in that MR, but were marked to be fixed in a follow-up.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Tian
  • Daniel Tian
  • 83 83 this.updateRouteQuery();
    84 84 },
    85 85 updateRouteQuery() {
    86 if (!this.$route) {
  • Daniel Tian added 1 commit

    added 1 commit

    • f900456b - Improve pipeline security tab filter logic

    Compare with previous version

  • Daniel Tian
  • Daniel Tian added 1 commit

    added 1 commit

    • ee3938ad - Improve pipeline security tab filter logic

    Compare with previous version

  • 🤖 GitLab Bot 🤖 changed milestone to %13.6

    changed milestone to %13.6

  • Daniel Tian added 1 commit

    added 1 commit

    • 7a3e422b - Improve pipeline security tab filter logic

    Compare with previous version

  • Daniel Tian added 15 commits

    added 15 commits

    Compare with previous version

  • Author Developer

    @andr3 Would you be able to do the initial review for this one? :bow:

  • assigned to @andr3

  • mentioned in issue #281949 (closed)

  • Daniel Tian
  • André Luís
  • @dftian left a couple of comments but LGTM overall.

    Feel free to move to maintainer review.

  • André Luís assigned to @dftian and unassigned @andr3

    assigned to @dftian and unassigned @andr3

  • Author Developer

    @ntepluhina Would you mind doing the maintainer review for this one? :bow: I'm manually assigning it to you to spread the load out more evenly (Ezekiel already has 1 MR assigned to him).

  • Daniel Tian assigned to @ntepluhina and unassigned @dftian

    assigned to @ntepluhina and unassigned @dftian

  • Natalia Tepluhina resolved all threads

    resolved all threads

  • Natalia Tepluhina assigned to @dftian and unassigned @ntepluhina

    assigned to @dftian and unassigned @ntepluhina

  • Daniel Tian added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Tian assigned to @ntepluhina and unassigned @dftian

    assigned to @ntepluhina and unassigned @dftian

  • Daniel Tian added 629 commits

    added 629 commits

    Compare with previous version

  • Natalia Tepluhina resolved all threads

    resolved all threads

  • Natalia Tepluhina approved this merge request

    approved this merge request

  • Natalia Tepluhina assigned to @dftian and unassigned @ntepluhina

    assigned to @dftian and unassigned @ntepluhina

  • 🤖 GitLab Bot 🤖 changed milestone to %13.7

    changed milestone to %13.7

  • Daniel Tian added 655 commits

    added 655 commits

    Compare with previous version

  • Daniel Tian assigned to @ntepluhina and unassigned @dftian

    assigned to @ntepluhina and unassigned @dftian

  • Natalia Tepluhina resolved all threads

    resolved all threads

  • mentioned in commit 57cb447e

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading