Improve pipeline security tab filter logic
What does this MR do?
This MR addresses the feedback left in !47294 (merged). The previous MR was merged quickly in order to fix a priority1 bug. This MR fixes the issues brought up in that MR, but were marked to be fixed in a follow-up.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines - [-] Style guides
- [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Merge request reports
Activity
changed milestone to %13.2
1 Warning 6442c671: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 47721 "Improve pipeline security tab filter logic"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 47721 "Improve pipeline security tab filter logic"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Justin Boyson ( @jboyson
) (UTC-6, 4 hours ahead of@dftian
)Ezekiel Kigbo ( @ekigbo
) (UTC+11, 21 hours ahead of@dftian
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 757 commits
-
f16f55cd...863b2d18 - 756 commits from branch
master
- 6d50dd19 - Fix pipeline security tab filters
-
f16f55cd...863b2d18 - 756 commits from branch
added 756 commits
-
f16f55cd...863b2d18 - 756 commits from branch
master
-
f16f55cd...863b2d18 - 756 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 801d158b and 25d1da16
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.14 MB 3.14 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Natalia Tepluhina
- Resolved by Natalia Tepluhina
- Resolved by Natalia Tepluhina
83 83 this.updateRouteQuery(); 84 84 }, 85 85 updateRouteQuery() { 86 if (!this.$route) { changed this line in version 5 of the diff
- Resolved by Natalia Tepluhina
changed milestone to %13.6
added missed-deliverable missed:13.2 labels
added 15 commits
-
7a3e422b...60aaf864 - 14 commits from branch
master
- 538ad2fd - Improve pipeline security tab filter logic
-
7a3e422b...60aaf864 - 14 commits from branch
added sectionsec label
@andr3 Would you be able to do the initial review for this one?
assigned to @andr3
mentioned in issue #281949 (closed)
- Resolved by André Luís
- Resolved by Natalia Tepluhina
@dftian left a couple of comments but LGTM overall.
Feel free to move to maintainer review.
@ntepluhina Would you mind doing the maintainer review for this one?
I'm manually assigning it to you to spread the load out more evenly (Ezekiel already has 1 MR assigned to him).assigned to @ntepluhina and unassigned @dftian
- Resolved by Natalia Tepluhina
- Resolved by Natalia Tepluhina
@dftian thank you for working on the follow-up! I've added a single suggestion about GitLab UI classes, rest LGTM
assigned to @dftian and unassigned @ntepluhina
assigned to @ntepluhina and unassigned @dftian
added 629 commits
-
2060b19a...5dd595b6 - 627 commits from branch
master
- 659c3f29 - Improve pipeline security tab filter logic
- 6753438f - Use GitLab utility classes
-
2060b19a...5dd595b6 - 627 commits from branch
- Resolved by Natalia Tepluhina
@dftian ouch! It seems now we have a merge conflict, could you please resolve it and assign back to me for merge?
assigned to @dftian and unassigned @ntepluhina
changed milestone to %13.7
added missed:13.6 label
added 655 commits
-
6753438f...a8993d30 - 653 commits from branch
master
- 6442c671 - Improve pipeline security tab filter logic
- 25d1da16 - Use GitLab utility classes
-
6753438f...a8993d30 - 653 commits from branch
assigned to @ntepluhina and unassigned @dftian
mentioned in commit 57cb447e
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label