Re-align audit logs/events date fields in Firefox/Safari
What does this MR do?
As per #281909 (closed) the date fields and their labels were misaligned on Firefox and later I noticed in Safari too. This MR fixes this alignment and also fixes the issue where the end date field and sorting dropdown would sit snuggly next to each other on these browsers as well.
Note: Each browser isn't showing the exact same spacing differences (some wider, some shorter) at different widths but that is okay, it appears to be related to how they calculate flex position and doesn't detrimentally affect the usability for the user.
Screenshots (strongly suggested)
browser | desktop | mobile |
---|---|---|
Chrome | ![]() |
![]() |
Firefox | ![]() |
![]() |
Edge | ![]() |
![]() |
Safari | ![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
- Using different browsers go to
[HOST]/admin/audit_logs
and also[HOST]/groups/[GROUP]/-/audit_events
- Check that on different screen sizes, the labels align centrally with the inputs and there is the spacing between each input and the next
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
-
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #281909 (closed)
Edited by Robert Hunt