Skip to content

Re-align audit logs/events date fields in Firefox/Safari

Robert Hunt requested to merge 281909-date-field-misaligned-in-firefox into master

What does this MR do?

As per #281909 (closed) the date fields and their labels were misaligned on Firefox and later I noticed in Safari too. This MR fixes this alignment and also fixes the issue where the end date field and sorting dropdown would sit snuggly next to each other on these browsers as well.

Note: Each browser isn't showing the exact same spacing differences (some wider, some shorter) at different widths but that is okay, it appears to be related to how they calculate flex position and doesn't detrimentally affect the usability for the user.

Screenshots (strongly suggested)

browser desktop mobile
Chrome image image
Firefox image image
Edge image image
Safari image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

  1. Using different browsers go to [HOST]/admin/audit_logs and also [HOST]/groups/[GROUP]/-/audit_events
  2. Check that on different screen sizes, the labels align centrally with the inputs and there is the spacing between each input and the next

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #281909 (closed)

Edited by Robert Hunt

Merge request reports