Skip to content

Implement `deactivated?` for deploy tokens

Dominic Couture requested to merge deploy-token-policy-actor-deactivated into master

What does this MR do?

This addresses a minor finding from https://gitlab.com/gitlab-com/gl-security/appsec/appsec-reviews/-/issues/37

Context:

The problem is that deploy tokens can indeed be deactivated but they respond to the active? method instead. This implements deactivated? to make sure the active status is correctly taken into account should the deploy token be used for a policy. It shouldn't happen and probably doesn't but better safe than sorry!

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Dominic Couture

Merge request reports