Implement `deactivated?` for deploy tokens
What does this MR do?
This addresses a minor finding from https://gitlab.com/gitlab-com/gl-security/appsec/appsec-reviews/-/issues/37
Context:
- Deploy tokens are
PolicyActor
s -
PolicyActor
defines adeactivated?
method that returnsfalse
The problem is that deploy tokens can indeed be deactivated but they respond to the active?
method instead. This implements deactivated?
to make sure the active status is correctly taken into account should the deploy token be used for a policy. It shouldn't happen and probably doesn't but better safe than sorry!
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Dominic Couture