Skip to content

Update ElasticDeleteProjectWorker to not be dependent upon project join

Terri Chu requested to merge 273234-update-elastic-delete-project-worker into master

What does this MR do?

Related to #273234 (closed)

Remove reliance on parent joins for Elasticsearch query to delete associated records in ES when a project gets deleted. For issues, notes, and milestones that means just querying by project_id which each of them index already. For merge requests, target_project_id is used since that is what project_id is aliased to in the model.

Added one test to spec to verify all data is removed.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Terri Chu

Merge request reports