Skip to content

Fix scoped labels color regression in dark mode

euko requested to merge fix-labels-regression-in-dark-mode into master

What does this MR do?

  • Updates "_dark.scss" to correctly display label texts both in normal and dark mode
    • Use white-ish($gray-900: #fafafa) text in scoped labels.

This update fixes #270389 (closed).


To see the changes in this MR, you must invalidate markdown cache

The rendered markups for labels are cached to be used in discussion notes and todo items!

https://docs.gitlab.com/ee/administration/invalidate_markdown_cache.html#invalidate-markdown-cache

Screenshots (strongly suggested)

before after
Screen_Shot_2020-11-13_at_1.04.55_PM Screen_Shot_2020-11-17_at_1.43.40_PM
Screen_Shot_2020-11-13_at_1.04.30_PM Screen_Shot_2020-11-17_at_1.45.48_PM
- Screen_Shot_2020-11-17_at_1.44.38_PM
- Screen_Shot_2020-11-17_at_1.47.20_PM
- Screen_Recording_2020-11-17_at_1.49.22_PM
_ Screen_Recording_2020-11-17_at_1.47.51_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by euko

Merge request reports