Skip to content

Add .rubocop_manual_todo.yml to code patterns

Peter Leitzen requested to merge pl-add-rubocop-manual-todo-rules into master

What does this MR do?

When we added .rubocop_manual_todo.yml in !46477 (merged) we missed to add it to code patterns in our CI yaml so the pipeline looks very light if an MR contains changes only in .rubocop_manual_todo.yml.

Example !47549 (merged)

Screenshot_from_2020-11-12_18-57-49

Verification

The MR !47557 (closed) demonstrates the before and after we add .rubocop_manual_todo.yml to code patterns.

Before (target master) After (target pl-add-rubocop-manual-todo-rules)
Screenshot_from_2020-11-12_19-38-20 Screenshot_from_2020-11-12_19-39-37

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports