Prettify mapping builder form
http_integrations_list && multiple_http_integrations_custom_mapping
To check navigate to Settings=>Operations=>Alerts=> Select HTTP Endpoint (in Select integration type dropdown)=>Toggle Active toggle ON=>Press "Submit payload" (Currently interaction with BE is mocked so it doesn't matter what test payload field contains)
What does this MR do?
- Aligns controls on mapping builder form based on UX feedback
- Adds toast message on successful payload parse
- adds
aria-labelledbyattribute to each control referencing column header based on this discussion gitlab-svgs#159 (comment 437106979) (I've opted for labelledby instead of describedby based on this article)
Plan for the feature rollout on frontend side
| header | header |
|---|---|
| Introduce feature flag, add placeholder for Mapping Builder |
|
| Add mapping builder form with mocked data |
|
| Add linking arrow |
|
| Mock communication with BE for sample payload parse and read |
|
| Prettify the form | workflowin review Current MR !47512 (merged) |
| Integrate parsing alert payload with backend | |
| Send test alert - integration with backend | |
| Save form - integration with backend | |
| Remove feature flag |
Screenshots (strongly suggested)
Mapping fields
Parsing & mapping
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #280851 (closed)
Edited by Olena Horal-Koretska