Skip to content

Stop finding commit with empty ref

Patrick Bajao requested to merge 280795-stop-finding-commit-empty-ref into master

What does this MR do?

When Projects::RefsController#switch is requested without ref and path params, internally, GitLab still tries to make a request for FindCommit RPC with empty ref.

We don't need to do that as we won't be able to find a commit with empty ref.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #280795 (closed)

Merge request reports