Skip to content

Fix syntax highlight issue with regular expressions

Tan Le requested to merge 276911-fix-ruby-lexer-rouge-bug into master

What does this MR do?

Fix syntax highlight issue with regular expressions.

We can observe this bug when viewing files which contain regular expressions.

https://gitlab.com/gitlab-org/gitlab/-/blob/master/spec/lib/gitlab/path_regex_spec.rb

Screenshots

Before After
Screen_Shot_2020-11-12_at_2.24.16_pm Screen_Shot_2020-11-12_at_2.24.28_pm
http://rouge.jneen.net/v3.24.0/ruby/L28vID1-ICJmb28i http://rouge.jneen.net/v3.25.0/ruby/L28vID1-ICJmb28i

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #276911 (closed)

Edited by Tan Le

Merge request reports