Draft: Resolve "FE: Add severity counters to Group and Instance Vulnerability Reports"
requested to merge 262109-fe-add-severity-counters-to-group-and-instance-vulnerability-reports into master
What does this MR do?
It is a POC that outlines a possible implementation of Add severity counters to Group and Instance Vulnerability Reports
The idea is to let VulnerabilityCountList
handle the data fetching and let the consuming component control the scope of the vulnerability count (project
, group
or instance
) via a simple prop:
// project level
<vulnerabilities-count-list scope="project" :full-path="projectFullPath" :filters="filters" />
// group level
<vulnerabilities-count-list scope="group" :full-path="groupFullPath" :filters="filters" />
// instance level
<vulnerabilities-count-list scope="instance" :filters="filters" />
Note: The pattern of having a single GraphQL query to handle all three scenarios is inspired by app/assets/javascripts/boards/queries/board_labels.query.graphql
From a MR POV this could be split up into:
- Refactor
vulnerabilities-count-list
and the query - Add
vulnerabilities-count-list
to group level - Add
vulnerabilities-count-list
to instance level
TODO:
-
Docs -
update copies -
update screenshots
-
-
Update specs for: -
vulnerability-count-list
-
first-class-project-security-dashboard
-
first-class-group-security-dashboard
-
first-class-instance-security-dashboard
-
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #262109 (closed)
Edited by David Pisek