Skip to content

Add confirm modal to unblock user

Doug Stull requested to merge 267118-add-modal-to-unblock into master

What does this MR do?

Add the modal confirmation to unblocking the user. This will make it match all other areas on this page.

Test Locally

  • User index area: Visit admin/users area and click on any user to block/then unblock - similar to http://127.0.0.1:3000/admin/users/asdfasdf
  • User show area: Visit admin/users area and click block on any user, from this URL http://127.0.0.1:3000/admin/users, then visit the blocked tab and unblock them.

Screenshots (strongly suggested)

User index area:

before after
Screen_Recording_2020-11-12_at_1.22.35_PM Screen_Recording_2020-11-12_at_1.17.58_PM

User show area:

Before After
Screen_Recording_2020-11-11_at_2.52.35_PM Screen_Recording_2020-11-11_at_2.49.23_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #267118

Edited by Doug Stull

Merge request reports