Fix comment for diff note images
What does this MR do?
Related issue: #213989 (closed)
We don't need to recalculate diff note positions for image notes, they are displayed correctly for master (HEAD)
and master (base)
. This merge request just fixes the code-comment about it.
Merge request reports
Activity
changed milestone to %13.6
added backend devopscreate groupsource code labels
mentioned in issue #213989 (closed)
2 Warnings Please add a throughput label to this merge request. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 47400 "Fix comment for diff note images"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 47400 "Fix comment for diff note images"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Drew Cimino ( @drewcimino
) (UTC-5, 8 hours behind@igor.drozdov
)Vitali Tatarintev ( @ck3g
) (UTC+1, 2 hours behind@igor.drozdov
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Igor Drozdov
@ck3g could you please review this merge request?
assigned to @ck3g
Setting label(s) Category:Source Code Management sectiondev based on groupsource code.
added Category:Source Code Management sectiondev labels
enabled an automatic merge when the pipeline for f56fe1db succeeds
mentioned in commit 7a5d64de
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label