Skip to content

Add a rule to enforce resolver type annotations

Alex Kalderimis requested to merge ajk-rubocop-resolver-type into master

What does this MR do?

This MR adds a new Rubocop rule: Graphql/ResolverType.

This rule enforces that every resolver declares its type explicitly using a top level DSL method.

The reasons for this are:

  • Executable documentation: developers can see what a resolver returns
  • SSOT for field metadata. We currently are being wasteful in this regard, since fields that have resolver classes can inherit the resolver's field options. There is never a reason for a field to override the type, so we should encourage fields with resolvers to delegate to the resolver for all metadata. For this to work, the resolvers will need to have this metadata defined in all cases, so this cop is the first step.
  • Enable better testing of resolvers. To test resolvers properly we need to generate fields for them. To do this we need a type definition.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Luke Duncalfe

Merge request reports