Skip to content

[RUN AS-IF-FOSS] Add association between DeployKey and PushAccessLevel

Etienne Baqué requested to merge 30769-add-deploy-key-id into master

What does this MR do?

After that MR, this MR here is another round of extracting code from a bigger MR to introduce a new feature more gently (Deploy Keys selectable on Protected Branches)

This MR here focuses on establishing the new association, at the model level, between PushAccessLevel and DeployKey.

Screenshots (strongly suggested)

Some quick manual testing to make sure that we still maintain the current ("deploy-key-free") UI.

FOSS:

Screenshot_from_2020-11-11_10-12-43

EE (no deploy key entries after users, in the dropdown):

Screenshot_from_2020-11-11_10-14-51

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #30769 (closed)

Edited by Etienne Baqué

Merge request reports