Skip to content
Snippets Groups Projects

Explain new sast / dependency_scanning error that was introduced in 13.4

Merged Ben Prescott_ requested to merge docs-bprescott-20201110-sastds into master
All threads resolved!

What does this MR do?

Explains the error [sast|dependency_scanning] is used for configuration only, and its script should not be executed

Customer raised a ticket for it, as they were adding rules to sast in 12.x and when they upgraded to 13.5 their CI started generating this error.

Related issues

Author's checklist (required)

Do not add the feature, frontend, backend, ~"bug", or database labels if you are only updating documentation. These labels will cause the MR to be added to code verification QA issues.

When applicable:

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

For more information about labels, see Technical Writing workflows - Labels.

For suggestions that you are confident don't need to be reviewed, change them locally and push a commit directly to save others from unneeded reviews. For example:

  • Clear typos, like this is a typpo.
  • Minor issues, like single quotes instead of double quotes, Oxford commas, and periods.

For more information, see our documentation on Merging a merge request.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Russell Dickenson resolved all threads

    resolved all threads

  • added 1 commit

    • f7e37279 - Apply 5 suggestion(s) to 3 file(s)

    Compare with previous version

    • Resolved by Ben Prescott_

      @bprescott_ Thanks for catching this! Indeed, we should mention this limitation in the docs. That said, it should be possible to override sast and dependency_scanning, and that's something we leverage in the configuration UI. What's not allowed is to enable these jobs by changing their rules. Does this clarify the behavior? Am I missing something?

  • assigned to @bprescott_ and unassigned @fcatteau and @rdickenson

  • Ben Prescott_ added 167 commits

    added 167 commits

    Compare with previous version

  • assigned to @fcatteau and @rdickenson and unassigned @bprescott_

    • Resolved by Russell Dickenson

      @bprescott_ Thanks for updating the MR! I suggest we focus on the limitations of sast and dependency_scanning, and keep it as short as possible. Reading this it feels like there are gaps in the documentation of SAST and Dependency Scanning, and your addition to the troubleshooting sections is filling the gaps. cc @rdickenson

      Re-assigning to you, and assigning to @theoretick as well. Not only does it touch SAST (owned by groupstatic analysis), but I need a second opinion on this tricky change anyways.

  • assigned to @theoretick and @bprescott_ and unassigned @fcatteau

  • 🤖 GitLab Bot 🤖 changed milestone to %13.7

    changed milestone to %13.7

  • 🤖 GitLab Bot 🤖 changed milestone to %13.8

    changed milestone to %13.8

  • Ben Prescott_ added 1 commit

    added 1 commit

    • 2aae0893 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ben Prescott_ added 1 commit

    added 1 commit

    • c9e709e0 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ben Prescott_ added 9392 commits

    added 9392 commits

    Compare with previous version

  • Ben Prescott_ changed milestone to %13.9

    changed milestone to %13.9

  • Ben Prescott_ assigned to @rdickenson and unassigned @bprescott_

    assigned to @rdickenson and unassigned @bprescott_

  • Ben Prescott_ added 1 commit

    added 1 commit

    • 3f72003f - Explain 13.4 new SAST or DS error message

    Compare with previous version

  • Lucas Charles approved this merge request

    approved this merge request

  • Ben Prescott_ added 542 commits

    added 542 commits

    Compare with previous version

  • requested review from @rdickenson

  • added 1 commit

    • ff6e076c - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • e5577c26 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • 8c9ead34 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Russell Dickenson approved this merge request

    approved this merge request

  • Russell Dickenson resolved all threads

    resolved all threads

  • @bprescott_ - I've reviewed, approved, and merged this MR. :thumbsup:

  • mentioned in commit 7e5360bf

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #218541 (closed)

  • Please register or sign in to reply
    Loading