Skip to content

Remove write to PushRule#project_id from RepositoryController

Max Woolf requested to merge 46798-ignore-pushrule-project-id into master

What does this MR do?

Details in issue: #258649

PushRule#project_id is no longer used as PushRules belong to groups, projects. Previously a PushRule had a 1:1 relationship with a project and this is no longer the case.

  • Begins the process of removing push_rules.project_id from the database
  • Stops writing to PushRule#project_id when project PushRule is initially created
  • Adds delegation from PushRule to ProjectSetting
  • Does not affect end-user experience at all

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Woolf

Merge request reports