Fix top margin in "new project"

What does this MR do?

This MR fixes an issue introduced by !42769 (merged) which removed an element that was actually preventing some undesirable margin collapsing (specifically in the "New Project" page). Thankfully, we can force this through CSS without an empty element.

From the MDN docs on margin collapsing:

Margin collapsing occurs in three basic cases:

...

No content separating parent and descendants

If there is no border, padding, inline part, block formatting context created...

From the MDN docs on block formatting context:

A block formatting context is created by at least one of the following:

...

  • Flex items...

This is what the new gl-force-block-formatting-context does.

Screenshots (strongly suggested)

Before (on .com and master) After (this MR)
Screen_Shot_2020-11-06_at_3.51.16_PM Screen_Shot_2020-11-06_at_3.50.49_PM

Does this MR meet the acceptance criteria?

Conformity

Edited by Paul Slaughter

Merge request reports

Loading