Skip to content

Diff file view optimisations

Robert May requested to merge diff-file-view-optimisations into master

What does this MR do?

Primarily reduces variable instantiation when rendering diff views. Though minor, these will have performance benefits as we render larger and more numerous files, particularly in the _line partial, which is rendered potentially thousands of times in a single page load.

Related #232509 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert May

Merge request reports