Skip to content

Fix operations settings when Pipelines are disabled

Peter Leitzen requested to merge pl-fix-operations-settings-wo-pipelines into master

What does this MR do?

This MR fixes two backend ~bug s when the feature "Pipelines" (via Settings > General) is disabled for specific project.

  • Show Settings > Operations in the navigation
  • Show Settings > Operations > Error Tracking partial which also fixes the following a JavaScript error:

Screenshot_from_2020-11-06_14-51-11

This MR does make the JavaScript code more resilient because it's not needed after the backend fix.

Contributes to #276163 (closed)

Screenshots (strongly suggested)

Pipelines Before After
Disabled 🚫 Screenshot_from_2020-11-06_15-03-31 Screenshot_2020-11-06_Operations_Settings___Peter_Leitzen_mwps_1_ Screenshot_from_2020-11-06_15-02-07 Screenshot_2020-11-06_Operations_Settings___Administrator_manual_prometheus
Enabled Screenshot_from_2020-11-06_15-02-07 Screenshot_2020-11-06_Operations_Settings___Peter_Leitzen_mwps Screenshot_from_2020-11-06_15-02-07 Screenshot_2020-11-06_Operations_Settings___Administrator_manual_prometheus

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports