Fix Jira Connect styles not loaded when startup_css is enabled
What does this MR do?
Related to #273777 (closed)
On the Jira Connect app, custom CSS styles were not loading. This was due to code related to startup_css. We are using add_page_specific_style to include the CSS which then calls stylesheet_link_tag_defer. When startup_css is enabled, the stylesheet is included as media: print which only applies the styles when page is printed instead of applying them to "all" or "screen".
This change adds a param to the helper which allows us to disable the defer behaviour when not needed and use that in the jira_connect app.
I also update the order of includes in the jira_connect layout to group stylesheets and javascripts properly.
Screenshots (strongly suggested)
| Before | After |
|---|---|
 |
 |
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team