Skip to content

Add row highlight for alert settings

David O'Regan requested to merge http-highlight-current-edit into master

What does this MR do?

A small MVC to add row highlighting to the selected integration for editing inside the integration table for Alert settings.

This feature sits behind a feature flag: http_integrations_list for the frontend and multiple_http_integrations for the backend.

Design

design

This merge supports this Epic: &4442 (closed) and will come in the following stages:

Merge You are here
Add initial wrapper for new form and feature flag !45993 (merged)
Add GraphQL read endpoint to new form !46212 (merged)
Build out HTTP and Prometheus steps for new form / Add GraphQL Add HTTP endpoint to new form !46647 (merged)
Add GraphQL Update / Reset Token(Add GraphQL support for updating alert integrations) endpoint to new form !46697 (merged)
Add GraphQL delete integration endpoints(backend here: !45843 (merged) !46849 (merged)
Add ee support to add multiple endpoints !46889 (merged)
Add row highlighting 🤘
Opsgenie && Test Payload TBA
Abstraction/clean up TBA
Remove feature flag(UX review happens here to keep the cost of work low) and delete old form code / REST API code TBA

Screenshots (strongly suggested)

Not selected Selected
Screenshot_2020-11-05_at_17.49.30 Screenshot_2020-11-05_at_17.49.40

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #255603 (closed)

Edited by David O'Regan

Merge request reports