Skip to content

Resolve "Migrate Bootstrap button to GitLab UI GlButton in app/assets/javascripts/ide/components/terminal/session.vue"

What does this MR do?

Replaces the deprecated button styles with GlButton and the matching properties, and increases the size of the button from small to medium.

Screenshots (strongly suggested)

Before

Stop (Default) Stop (Hover)
Screenshot_2020-11-19_IDE Screenshot_2020-11-19_IDE_1_
Restart (Default) Restart (Hover)
Screenshot_2020-11-19_IDE_3_ Screenshot_2020-11-19_IDE_2_

After

Stop (Default) Stop (Hover)
Screen_Shot_2020-11-19_at_8.37.45_AM__2_ Screen_Shot_2020-11-19_at_8.34.38_AM__2_
Restart (Default) Restart (Hover)
Screenshot_2020-11-19_IDE_8_ Screenshot_2020-11-19_IDE_9_

In action

Button-migration

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #229282 (closed)

Edited by Tom Quirk

Merge request reports