Skip to content

Update deploytoken user impersonation guidelines

Ron Chan requested to merge rchan-gitlab-master-patch-66272 into master

What does this MR do?

This MR updates the secure coding guidelines on DeployToken impersonation, it recommends we always use user.is_a?(User) when dealing with an object that's expected to be an User.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports