Skip to content

Leverage CSS vs. JS for pipeline padding

Derek Knox requested to merge 239446-pipeline-graph-layout into master

What does this MR do?

  • Refactors away from a resize-JavaScript listener approach in favor of CSS-only so that the pipelines UI has the correct left-padding by default

Screenshots (strongly suggested)

Video of new behaviour:

Original_behaviour

Instance uses

Screen_Shot_2020-11-04_at_9.33.30_AM

Sidebar style accounted for

Screen_Shot_2020-11-04_at_9.34.01_AM

Container style accounted for

Screen_Shot_2020-11-04_at_9.34.13_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #239446 (closed)

Edited by Frédéric Caplette

Merge request reports