Skip to content

Resolve "undefined method `allow_mfa_for_subgroups' for nil:NilClass after upgrading to 13.5.1 (8ee0746f54c)"

What does this MR do?

There were reports on groups created and throwing 500 error on edit page (/groups/name/-/edit). It happened when group was created via admin panel - it was caused by lack of namespace_settings record, it was not created when creating group via admin panel, as it does not use service as api endpoint and main interface controller.

This fixes it plus adds migration to fix inconsistencies in the data.

Screenshots (strongly suggested)



== 20201104124300 EnsureNamespaceSettingsCreation: migrating ==================
== 20201104124300 EnsureNamespaceSettingsCreation: migrated (0.0582s) =========

Does this MR meet the acceptance criteria?


Availability and Testing


If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #273380 (closed)

Edited by Gosia Ksionek

Merge request reports