Check if all replication and verification succeeded
What does this MR do?
This MR resolves the bug #273194 (closed) by counting the total number of successful replication and verifications instead of counting total number of failures.
When a replication/verification fails, the failed count for the item is incremented. But when an item hasn't started syncing, it is not accounted for in failed_counts. So, we need to check if all items were successfully replicated/verified, instead.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team