Fixes ssh key deletion notification
What does this MR do?
- Fixes a bug (deployed by a default-off feature flag) that caused credential deletion notifications not to send.
This is due to the fact that the mailer job is sent the global ID of the credential to be revoked. For PATs this is not a problem since revocation doesn't actually remove the object from the database.
SSH keys are deleted, rather than revoked, so passing a reference to the object in to a background job causes the job to fail since the object no longer exists.
This MR passes the metadata for SSH keys to the background job, instead of the reference to the object itself to avoid this error.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry Behind feature flag
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #250354 (closed)