Skip to content

Add a loding indicator for the submit button in the CI lint page

Miguel Rincon requested to merge 249661-ci-lint-loading-button into master

What does this MR do?

This change is behind and FF, more at: #249661 (closed)

Add a loading indicator for the submit button.

In large CI configurations, the time to give feedback can increase, so users might think the UI is not responding as the validation occurs.

When the user ask to lint a CI config, the feedback may take over a few seconds, they should get feedback that the system is working.

Screenshots (strongly suggested)

Note the "Validate" button, now it has a loading icon when the user ask to load.

2020-11-02_12.21.57

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #249661 (closed)

Edited by Miguel Rincon

Merge request reports