Skip to content

Move constant values to props in PipelineScvhedulesCallout

Vitaly Slobodin requested to merge vs-remove-nonreactive-data into master

What does this MR do?

Constant values like URLs and image URLs does not need to be reactive. For performance reasons we should move them to props.

This MR also converts existing tests to VTU.

Closes #257823 (closed).

Screenshots (strongly suggested)

No visual changes as required.

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vitaly Slobodin

Merge request reports