Skip to content

GitLab Next

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 39,511
    • Issues 39,511
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1,222
    • Merge requests 1,222
  • Requirements
    • Requirements
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
    • Value stream
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !46549

Merged
Created Oct 30, 2020 by Maxime Orefice@morefice🌴Developer5 of 5 tasks completed5/5 tasks

Add code coverage summary resolver

  • Overview 26
  • Commits 2
  • Pipelines 7
  • Changes 11

What does this MR do?

Following up !44472 (merged)

This MR clean up some technical debt by refactoring 2 things.

It includes the following items:

  • Change lastUpdatedAt to a Types::DateType to be more specific of this datatype
  • Move CodeCoverageSummaryResolver to its own resolver ee/spec/graphql/resolvers/ci

Why are we doing this?

According to our documentation this is the best practices commanded.

Does this MR meet the acceptance criteria?

Conformity

  • [-] Changelog entry
  • [-] Documentation (if required)
  • Code review guidelines
  • [-] Merge request performance guidelines
  • Style guides
  • [-] Database guides
  • Separation of EE specific content

Availability and Testing

  • [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • [-] Tested in all supported browsers
  • [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: mo-code-coverage-project-resolver

Enable Gitpod?

To use Gitpod you must first enable the feature in the integrations section of your user preferences.

Cancel Enable Gitpod