Skip to content

Replace current_user context call with method [RUN AS-IF-FOSS]

charlie ablett requested to merge cablett-current-user-graphql into master

What does this MR do?

base_resolver.rb, base_object.rb and base_mutation.rb all have a shortcut method current_user which calls context[:current_user]. I noticed subclasses of these types use the long method rather than the shortcut method.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by charlie ablett

Merge request reports