Skip to content

Add update_sequence_id to JiraConnect workers

What does this MR do?

This is the first part of a multi release effort to make JiraConnect workers idempotent. It adds an argument with a default value to the workers.

The workers sync repository and merge request data with Jira. They send an API request containing a update_sequence_id which is generated from a timestemp and helps Jira to avoid conflicts.

In my first attempt to make the workers idempotent, it was discovered that update_sequence_id would change when the worker would run twice with the same argument and because of this wouldn't be idempotent. To fix this, update_sequence_id needs to be generated outside the worker and provided as an argument.

Related MRs:

Related Issues:

-#229174 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Andy Schoenen

Merge request reports