Skip to content

Correct grammar error in "Sign-in restrictions" text labels

Mike Jang requested to merge 273623-replace-sign-in-text-with-sign-in-text into master

What does this MR do?

The current "Sign-in restrictions" modal, accessible from Admin Area > Settings > General, includes two labels with grammar errors.

Specifically:

  • "After sign out path" should be "After sign-out path", as "sign-out" is the noun, and "sign out" is the verb
  • "Sign in text" should be "Sign-in text", for similar reasons

Screenshots (strongly suggested)

Current:

Screenshot_from_2020-10-29_08-59-33

After the change:

Screenshot_from_2020-10-29_13-43-45

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #273623 (closed)

Edited by Mike Jang

Merge request reports