Skip to content

Add cutoff in pipeline graph on lines that dont connects

What does this MR do?

Add a cutoff on lines that goes under a job pill but aren't actually connected. For this to work, we have a new util function that takes our needs object and reduce it to a single array that contains all the jobs that have links. If a job isnt in that list, we add the "cut off" effect so that any line that goes under it will look disconnected.

Screenshots (strongly suggested)

Before

Screen_Shot_2020-10-29_at_11.12.18_AM

Screen_Recording_2020-10-29_at_11.12.22_AM

After

Screen_Shot_2020-10-29_at_11.14.28_AM

Screen_Recording_2020-10-29_at_11.19.11_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports