Compute UUID before creating or updating Finding
What does this MR do?
After merging !43881 (merged) we noticed that we still generate UUIDv4 for Vulnerabilities. It turned out that the #update_vulnerability_finding method in Security::StoreReportService uses old Finding params and overwrites the previously calculated UUIDv5.
At this point we should have a follow up issue to simplify Security::StoreReportService because it's increasingly hard to reason about.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #212322 (closed)
Edited by Mark Chao