Move marketing opt in to welcome page
What does this MR do?
Engineering Issue: #273192 (closed)
Design Issue: gitlab-org/growth/team-tasks#162 (closed)
This moves the marketing email opt in checkbox to the welcome page as well as putting users who have chosen to use GitLab for their company opt-in per default.
How to try it out
- Go to http://localhost:3000/users/sign_in#register-pane
- Fill in the form & Sign up
- You're on the welcome page. Switch between "Setup for me" and "Setup for company"
Screenshots (strongly suggested)
Registration Form
| Before | After |
|---|---|
 |
 |
Welcome Page
| Before | After (company) | After (just me) |
|---|---|---|
 |
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular