Add Sidekiq job for importing CSV requirements async
What does this MR do?
Related to #249182 (closed)
As a follow up to !46361 (merged), this MR adds a Sidekiq job in order to enable scheduling CSV requirements import and perform it async.
This job would be scheduled in the next iteration MR where we add a GraphQL mutation to import the requirements.
Update: This job would be scheduled in the next iteration MR where we add an API endpoint to import the requirements. (The implementation changed due to lack of support for direct upload in GraphQL uploads. See #246857 (comment 448347386)).
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #249182 (closed)
Merge request reports
Activity
changed milestone to %13.6
removed workflowin dev label
removed [deprecated] Accepting merge requests label
mentioned in merge request !46361 (merged)
added 1401 commits
-
24304fd1...cec6b374 - 1400 commits from branch
master
- 00e9e3b9 - Add worker for import csv requirements
-
24304fd1...cec6b374 - 1400 commits from branch
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Reuben Pereira ( @rpereira2
) (UTC+5.5, 5.5 hours ahead of@egrieff
)Sean McGivern ( @smcgivern
) (UTC+0, same timezone as@egrieff
)Sidekiq queue changes
This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.
These queues were added:
requirements_management_import_requirements_csv
If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖marked the checklist item Changelog entry as completed
- Resolved by Sean McGivern
@gitlab-org/scalability could I have a review for the new queue
requirements_management_import_requirements_csv
please?🙇 It should be very similar to
import_issues_csv
but I couldn't calculate the new values for Total Execution Time and Throughput (RPS).
- Resolved by Bob Van Landuyt
@alipniagov Would you mind reviewing, please?
🙇
assigned to @alipniagov
unassigned @alipniagov
@reprazent would you mind taking the maintainer review, please?
🙇 assigned to @reprazent
- Resolved by Bob Van Landuyt
- Resolved by Bob Van Landuyt
- Resolved by Bob Van Landuyt
- Resolved by Bob Van Landuyt
- Resolved by Bob Van Landuyt
Thanks @egrieff, left some comments.
unassigned @reprazent
mentioned in issue #281173 (closed)
assigned to @reprazent
- Resolved by Albert Salim
unassigned @reprazent
added 1305 commits
-
d2bf1b62...4634c240 - 1303 commits from branch
master
- ab372d3e - Add worker for import csv requirements
- c7183845 - Make worker idempotent
-
d2bf1b62...4634c240 - 1303 commits from branch
mentioned in issue #283931
mentioned in merge request !47808 (merged)
mentioned in issue #246857 (closed)
changed milestone to %13.7
added 785 commits
-
8f2481a7...f5bd4c28 - 783 commits from branch
master
- 1a9de47f - Add worker for import csv requirements
- df0b1e57 - Make worker idempotent
-
8f2481a7...f5bd4c28 - 783 commits from branch
assigned to @reprazent
Thanks @egrieff! LGTM!
enabled an automatic merge when the pipeline for 4102a7ef succeeds
mentioned in commit e09933bf
mentioned in issue gitlab-com/gl-infra/scalability#672
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request !48060 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label