Skip to content

Get feature flag definitions via API

Kamil Trzciński requested to merge validate-feature-flag-used into master

What does this MR do?

This is a preliminary work for #273167 (closed).

This is based on: !45904 (merged). It is done, but the !45904 (merged) should be merged first.

ChatOps change: gitlab-com/chatops!158 (closed).

It makes us

  1. Load feature flag definitions in production (which is done at load time)
  2. Makes us validate feature flag name used on POST => This will be a follow-up and should be merged after gitlab-com/chatops!158 (closed).
  3. Return definition details on GET/POST

Why

  1. This is to ensure that only a defined feature flags are used
  2. Still allow to skip the check if we did not cover all feature flags.

Impact

  1. Since no all type: :ops are tracked, for them it will require --force to be used
  2. We will be able to show as part of ChatOps current and obsolete feature flags!!!

This misses

  1. ChatOps change to add --force

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Shinya Maeda

Merge request reports