Fix ClusterReindexingService infinite loop
What does this MR do?
This MR fixes a bug when after triggering cluster zero-downtime reindexing we receive 404 exception. Instead of being stuck in an infinite loop, we handle this gracefully and fail a reindexing task.
$ curl -XGET 'http://localhost:9200/_tasks/-bRdhZ5ZT421rVk6JJLJ0w:37882'
{"error":{"root_cause":[{"type":"resource_not_found_exception","reason":"task [-bRdhZ5ZT421rVk6JJLJ0w:37882] isn't running and hasn't stored its results"}],"type":"resource_not_found_exception","reason":"task [-bRdhZ5ZT421rVk6JJLJ0w:37882] isn't running and hasn't stored its results"},"status":404}Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #257838 (closed)
Edited by Dmitry Gruzd