Skip to content

Validate composer version

Giorgenes Gelatti requested to merge 214429-validate-package-versions into master

What does this MR do?

Adds some composer package validation.

Composer package name comes from either a tag or branch name, which is validated by the creation service separately. So the package name is already guaranteed to conform to git branch name rules. Composer version specification seems very loose (https://getcomposer.org/doc/04-schema.md#version), so I'm adding semver validation on top of the tag name validation already in place. Semver should cover the composer spec.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #214429 (closed)

Edited by Giorgenes Gelatti

Merge request reports