Updating the 'stop all jobs' modal
What does this MR do?
Starts the process of updating app/assets/javascripts/pages/admin/jobs/index/components/stop_jobs_modal.vue
to use the new Pajamas integration. However, it doesn't currently finish the job.
The following files reference stop-jobs-modal
:
$ grep -riI "stop-jobs-modal" .
./app/views/admin/jobs/index.html.haml: #stop-jobs-modal
./app/views/admin/jobs/index.html.haml: target: '#stop-jobs-modal',
./app/assets/javascripts/pages/admin/jobs/index/index.js: el: '#stop-jobs-modal',
./app/assets/javascripts/pages/admin/jobs/index/index.js: return createElement('stop-jobs-modal', {
./app/assets/javascripts/pages/admin/jobs/index/components/stop_jobs_modal.vue: modal-id="stop-jobs-modal"
app/views/admin/jobs/index.html.haml
is beyond my ability to edit. This isn't a standard button, and I do not know how to edit this code:
- if @all_builds.running_or_pending.any?
#stop-jobs-modal
.nav-controls
%button#stop-jobs-button.btn.gl-button.btn-danger{ data: { toggle: 'modal',
target: '#stop-jobs-modal',
url: cancel_all_admin_jobs_path } }
= s_('AdminArea|Stop all jobs')
Acknowledgment: I haven't run yarn prettier
yet since I know there's more work to do.
I'm tagging in @ekigbo since that's what roulette is instructing me to do.
- Closes #229701 (closed)
- Related to &3939 (closed) (the modals epic)
Screenshots (strongly suggested)
Before | After |
---|---|
Screen_Recording_2020-10-27_at_11.48.39_am | Screen_Recording_2020-10-27_at_12.58.46_pm |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #229701 (closed)
Edited by David O'Regan