Skip to content

Migrate to GlTooltipDirective in Web IDE components/mr_file_icon.vue

Marcia Ramos requested to merge okr-tooltip-merge-button-sidebar-ide into master

What does this MR do?

Closes #229017 (closed)

Screenshots (strongly suggested)

Seems the migration made it buggy:

BEFORE AFTER
tooltip-part-of-mr-button-before tooltip-part-of-mr-button

😕

How to get there:

  1. Open and edit a file, submit an MR through the Web IDE.
  2. From the IDE, click the branch name / MR button to open the drop-down.
  3. Click Merge Requests to check out the MR.
  4. Click on your MR. GitLab will refresh and open the Review tab.
  5. Go to the file tree and hover over the file you'd changed.

get-there

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marcia Ramos

Merge request reports