Skip to content

Add toggle to remove Analytics left nav item

What does this MR do?

Issue: #224700 (closed)

Allow to remove analytics nav item from the project's sidebar.

NOTE: This MR was originally implemented by @vyaklushin , but @cwoolley-gitlab is handling the review/merge phase, due to the reorg of the editor groups.

Screenshots (strongly suggested)

Toggle On Toggle Off
Screenshot_2020-10-23_at_14.33.02 Screenshot_2020-10-23_at_14.34.07

Tasks

Database

Migration output

➜  gitlab git:(224700_add_toggle_to_remove_analytics_item) rake db:migrate:up VERSION=20201021155606
== 20201021155606 AddAnalyticsAccessLevelToProjectFeatures: migrating =========
-- add_column(:project_features, :analytics_access_level, :integer, {:default=>20, :null=>false})
   -> 0.0016s
== 20201021155606 AddAnalyticsAccessLevelToProjectFeatures: migrated (0.0044s) 

➜  gitlab git:(224700_add_toggle_to_remove_analytics_item) ✗ rake db:migrate:down VERSION=20201021155606
== 20201021155606 AddAnalyticsAccessLevelToProjectFeatures: reverting =========
-- remove_column(:project_features, :analytics_access_level, :integer)
   -> 0.0012s
== 20201021155606 AddAnalyticsAccessLevelToProjectFeatures: reverted (0.0043s) 

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Chad Woolley

Merge request reports