Skip to content

Add app and audit event logs to PAT create and revoke services

What does this MR do?

  • Adds application and audit event logs to PAT creation service (required for #17176 (closed). See this comment)
  • Adds application and audit event logs to PAT revocation service to complement the feature.
  • Switches Profiles::PersonalAccessTokensController#create to use PersonalAccessTokens::CreateService
  • Creates a UserPolicy rule create_user_personal_access_token for use in PersonalAccessTokens::CreateService

Related issue: #276921 (closed)

Screenshot

Screenshot_2020-10-26_at_12.30.02_AM

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #17176 (closed)

Edited by Sanad Liaquat

Merge request reports