Add app and audit event logs to PAT create and revoke services
requested to merge 17176-add-application-and-audit-event-logs-for-create-revoke-pat-services into master
What does this MR do?
- Adds application and audit event logs to PAT creation service (required for #17176 (closed). See this comment)
- Adds application and audit event logs to PAT revocation service to complement the feature.
- Switches
Profiles::PersonalAccessTokensController#create
to usePersonalAccessTokens::CreateService
- Creates a UserPolicy rule
create_user_personal_access_token
for use inPersonalAccessTokens::CreateService
Related issue: #276921 (closed)
Screenshot
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #17176 (closed)
Edited by Sanad Liaquat