Remove extra empty space from MR page

What does this MR do?

remove some margin-bottom from the issue container on MR page. Instead add margin to the actual flash-error elements (so only add margin when there is actually an error)

Screenshots (strongly suggested)

before	after

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines

changed milestone to %13.6

added UI polish frontend labels

	1 Warning
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
frontend	Savas Vedova (@svedova) (UTC+3, 8 hours behind @psimyn)	Olena HK. (@ohoral) (UTC+2, 9 hours behind @psimyn)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

will need to re-add the space to some element to account for !39903 (merged)

On most pages the space comes from top padding on .detail-page-header, but on MR page we add .mt-0 (I think due to sticky tabs). Also having to visible borders at the top means it looks like too much space if we have paddingbottom from breadcrumbs and paddingtop from detail-page-header.

tldr probably changing the CSS to target .merge-request-container .flash-container > div is easiest..

/cc @zcuddy if you have any other ideas/input

added 1 commit

• f489c94c - Add margin to flash items themselves

Compare with previous version

added 1 commit

• 077040bb - Move to correct selector

Compare with previous version

changed the description

probably needs changelog

added 1 commit

• f926b13e - What a silly thing to break an entire pipeline

Compare with previous version

added 1 commit

• 38147490 - Add a changelog

Compare with previous version

assigned to @zcuddy

added 1 commit

• ec0b6b1d - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

approved this merge request

unassigned @zcuddy

changed target branch from psi-remove-board-list-vuex to master

added 447 commits

• ec0b6b1d...8ce3a303 - 441 commits from branch master
• cf61118b - Remove extra empty space from MR page
• b22d40fd - Add margin to flash items themselves
• 235b4fc7 - Move to correct selector
• 07e08ea3 - What a silly thing to break an entire pipeline
• e12f156b - Add a changelog
• 41180ff9 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added typemaintenance label

added typefeature label

added devopscreate merge requests labels and removed typefeature label

marked the checklist item Changelog entry as completed

marked the checklist item Code review guidelines as completed

marked the checklist item Merge request performance guidelines as completed

assigned to @ohoral

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits e071343a and 41180ff9

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.01 MB	3.01 MB	-	0.0 %
mainChunk	1.87 MB	1.87 MB	-	0.0 %

---

Note: We do not have exact data for e071343a. So we have used data from: 403ef67c.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for 5d1bcc13 succeeds

merged

mentioned in commit f27f8d47

added workflowstaging label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label