Fix for Security Reports Spec group dashboard
What does this MR do?
This is a proposed fix for #238848 (closed)
Upon investigation, it was noted that the group for which the group dashboard was being tested was a shared group that was used by previous tests.
Failure could be replicated by running the same batch of tests as a failed pipeline
CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://192.168.1.78:3000/ qa/specs/features/api/2_plan/closes_issue_via_pushing_a_commit_spec.rb qa/specs/features/api/3_create/gitaly/praefect_replication_queue_spec.rb qa/specs/features/api/3_create/merge_request/push_options_title_description_spec.rb qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb qa/specs/features/browser_ui/2_plan/related_issues/related_issues_spec.rb qa/specs/features/browser_ui/3_create/merge_request/view_merge_request_merge_ref_diff_spec.rb qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb qa/specs/features/browser_ui/3_create/snippet/create_personal_snippet_spec.rb qa/specs/features/browser_ui/3_create/web_ide/create_first_file_in_web_ide_spec.rb qa/specs/features/browser_ui/3_create/wiki/project_based_directory_management_spec.rb qa/specs/features/browser_ui/4_verify/pipeline/run_pipeline_via_web_only_spec.rb qa/specs/features/browser_ui/6_release/pipeline/parent_child_pipelines_dependent_relationship_spec.rb qa/specs/features/ee/api/enablement/elasticsearch/advanced_global_advanced_syntax_search_spec.rb qa/specs/features/ee/browser_ui/1_manage/group/group_file_template_spec.rb qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb qa/specs/features/ee/browser_ui/2_plan/issue_boards/configurable_issue_board_spec.rb qa/specs/features/ee/browser_ui/2_plan/issue_boards/read_only_board_configuration_spec.rb qa/specs/features/ee/browser_ui/2_plan/iterations/create_group_iteration_spec.rb qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb qa/specs/features/ee/browser_ui/enablement/elasticsearch/elasticsearch_reindexing_spec.rb qa/specs/features/ee/browser_ui/geo/geo_replication_npm_registry_spec.rb qa/specs/features/ee/browser_ui/geo/ssh_push_spec.rb qa/specs/features/ee/browser_ui/geo/wiki_ssh_push_to_secondary_spec.rb qa/specs/features/ee/browser_ui/secure/security_reports_spec.rb
This MR ensures that the test uses it's own group to test the group dashboard by creating a new group for the test project.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
Run the test batch in the description against master and note failing security_reports_spec
Run the same test batch against this branch and note passing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
/closes #238848 (closed)